Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-45: Support unknown column types #47

Merged
merged 3 commits into from
Jul 25, 2022
Merged

ISSUE-45: Support unknown column types #47

merged 3 commits into from
Jul 25, 2022

Conversation

fraenky8
Copy link
Owner

This PR does the following:

  • Moves the string-column type detection into the else- and default-branch. This leads to any unknown column type to be handles as a (nullable) string.
  • Adds a unit test for it for enum types for MySQL and PG.
  • Refactors the IsStringInSlice method to be standalone.

Fixes #45

@fraenky8 fraenky8 self-assigned this Jul 24, 2022
@ricardo-snyk
Copy link

@fraenky8 Thanks for fixing this!! I just tested this branch. It works as expected for Postgres!! 🚀

@fraenky8 fraenky8 merged commit 6ade5b0 into master Jul 25, 2022
@fraenky8 fraenky8 deleted the ISSUE-45 branch July 25, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not null enum columns return pointers
2 participants