Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Postgres connection DSN to URI prefixed with 'postgres://' to be able to connect to any DB that uses Postgres wire protocol #54

Merged
merged 3 commits into from
Jun 18, 2023

Conversation

aenawi
Copy link
Contributor

@aenawi aenawi commented Jun 10, 2023

A suggested fix for the issue #53

…ecause pg is waiting for it! Please refere to the discussion for referenced links.
Copy link
Owner

@fraenky8 fraenky8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Left some comments, please take a look 🙇‍♂️

pkg/settings/settings.go Outdated Show resolved Hide resolved
tables-to-go.go Outdated Show resolved Hide resolved
pkg/database/postgresql_test.go Outdated Show resolved Hide resolved
pkg/database/postgresql.go Outdated Show resolved Hide resolved
@aenawi
Copy link
Contributor Author

aenawi commented Jun 17, 2023

Done 🤝🏻
I hope I didn't miss anything!

Copy link
Owner

@fraenky8 fraenky8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fraenky8
Copy link
Owner

Thanks for this! I will update the vendor and polish the repo a bit and then tag/release a new version of this tool! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants