Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feedback received on Contribute Code/Docs documentation #238

Merged
merged 6 commits into from
May 26, 2022

Conversation

satendrapalsingh
Copy link
Contributor

@satendrapalsingh satendrapalsingh commented May 16, 2022

This PR collects and addresses the feedback received so far on the existing Contribute Code/Docs documentation.

Building-hasten instructions (when needed) should be on the Hasten repository README and not on 'docs.fragcolor.xyz'
Remove this page as :
> it's being added to the Clamor's README instead (fragnova/fragnova#51, fragnova/fragnova#65)
> and so shouldn't be a part of 'docs.fragcolor.xyz' (see comment #232 (comment))

See :
- Update the README clamor#51
- Enhance the Clamor README clamor#65)
- see comment
A placeholder page is needed as this link is currently referenced to in:
> fragcolor-xyz/shards-examples#9
> #235 (comment)
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #238 (20b5189) into devel (f8a353b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #238      +/-   ##
==========================================
- Coverage   61.46%   61.46%   -0.01%     
==========================================
  Files         109      109              
  Lines       22747    22736      -11     
==========================================
- Hits        13982    13974       -8     
+ Misses       8765     8762       -3     
Impacted Files Coverage Δ
src/core/blocks/network.cpp 90.90% <0.00%> (-1.82%) ⬇️
src/core/runtime.hpp 73.42% <0.00%> (-0.35%) ⬇️
src/core/blocks/flow.cpp 89.41% <0.00%> (-0.19%) ⬇️
src/core/blocks/wasm.cpp 49.76% <0.00%> (-0.16%) ⬇️
src/gfx/imgui/imgui.cpp 0.00% <0.00%> (ø)
src/core/ops_internal.cpp 73.51% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a353b...20b5189. Read the comment docs.

…g Tutorials doc

A placeholder page is needed for these pages as these links are currently referenced to in:
> Chianblocks primer, Contributing tutorials - fragcolor-xyz/shards-examples#9
> Chainblocks primer - #235 (comment)
docs/docs/architecture-guides/.pages Show resolved Hide resolved
docs/docs/how-to/.pages Outdated Show resolved Hide resolved
docs/docs/how-to/.pages Outdated Show resolved Hide resolved
@satendrapalsingh satendrapalsingh marked this pull request as ready for review May 24, 2022 03:55
@satendrapalsingh satendrapalsingh merged commit d6e65f7 into devel May 26, 2022
@satendrapalsingh satendrapalsingh deleted the docs_build-docs branch May 26, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants