Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Superfluous values in Child Charts #7

Closed
shin-go opened this issue Apr 19, 2023 · 0 comments
Closed

Remove Superfluous values in Child Charts #7

shin-go opened this issue Apr 19, 2023 · 0 comments

Comments

@shin-go
Copy link

shin-go commented Apr 19, 2023

Child charts like migrate do not have templates for Ingress resources, so they should be removed from that child chart's values.yaml. Even if helm simply disregards any declared values with defaults if they are not consumed, this is a bad practice and creates potential confusion for end users in the absence of a readme.md.
@jirevwe jirevwe closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jirevwe @shin-go