#42 Improve API, remove Arc that wraps the closure.

fralalonde · Mar 7, 2019 · 4a62271 · 4a62271
1 parent 5e35e68
commit 4a62271
Show file tree

Hide file tree

Showing 3 changed files with 293 additions and 286 deletions.
diff --git a/examples/observer.rs b/examples/observer.rs
@@ -20,7 +20,6 @@ extern crate dipstick;
 
 use std::fs::File;
 use std::io::{self, BufRead, BufReader};
-use std::sync::Arc;
 use std::time::{Duration, Instant};
 
 use dipstick::{AtomicBucket, InputScope, MetricValue, Prefixed, ScheduleFlush, Stream};
@@ -34,8 +33,8 @@ fn main() {
     metrics.set_drain(Stream::to_stderr());
     let flush_handle = metrics.flush_every(Duration::from_secs(1));
 
-    metrics.observe("uptime", Arc::new(move || dur2ms(start_time.elapsed())));
-    metrics.observe("threads", Arc::new(threads));
+    metrics.observe("uptime", move || dur2ms(start_time.elapsed()));
+    metrics.observe("threads", threads);
 
     println!("Press Enter key to exit");
     io::stdin().read_line(&mut String::new()).expect("Example, ignored");

diff --git a/src/bucket/atomic.rs b/src/bucket/atomic.rs
@@ -252,7 +252,7 @@ impl InputScope for AtomicBucket {
         InputMetric::new(move |value, _labels| scores.update(value))
     }
 
-    fn observe(&self, name: &str, callback: GaugeCallback) {
+    fn observe_helper(&self, name: &str, callback: GaugeCallback) {
         let gauge = self.gauge(name);
 
         write_lock!(self.inner)