Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching for all SBT tasks #75

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

rethab
Copy link
Contributor

@rethab rethab commented Aug 12, 2019

  • not having caching meant every time we run compile, the output files
    are deleted and freshly written. in a project with multiple modules
    and big swagger files, this leads to significant unnecessary overhead.

  • also added logging so that we see when things are compiled and made
    various other cleanups in the plugin.

  * not having caching meant every time we run compile, the output files
    are deleted and freshly written. in a project with multiple modules
    and big swagger files, this leads to significant unnecessary overhead.

  * also added logging so that we see when things are compiled and made
    various other cleanups in the plugin.
@rethab
Copy link
Contributor Author

rethab commented Aug 12, 2019

@andreaTP @fralken What do you think?

Please note that I created this PR (originally) based on the tag from 0.0.11, because that is the version we are using while master is already quite different. In fact, since master is currently not working for us and we'd have to do quite some migration (eg. see #74), how about the following:

  • Keep this on 0.0.11
  • For the refactoring on master, create version 0.1.0.

After that, I'd be happy to forward-port the changes, but I think the refactoring on master changes so many things that incrementing the second number should be easily justified.

@rethab rethab marked this pull request as ready for review August 12, 2019 11:08
@fralken
Copy link
Owner

fralken commented Aug 12, 2019

Hi @rethab, thanks for your PR. If you need this on top of version 0.0.11 we can merge it and publish a new version, say 0.0.12. Then it would be nice for you to port this on current master.

For sure master will be version 0.1.0 because there are a lot of changes since 0.0.11 such as code generation with scalameta, no more generation of non-scala code (e.g. routes), etc.

I would like to better isolate code generation from the plugin itself, now it is tightly coupled with Play code generation. This is my roadmap towards 0.1.0. But this requires some more work.

As for issue #74, I guess this should be fixed by the latest commits on master, let me know if this is the case.

@rethab
Copy link
Contributor Author

rethab commented Aug 12, 2019

@fralken sounds like a plan! Your code generation things are already on master though, aren't they? If so, are you going to drop them again or how shall we do this?

@fralken
Copy link
Owner

fralken commented Aug 13, 2019

We can create a branch from commit tagged 0.0.11, apply your PR, update version and tag to 0.0.12, publish it and then merge it to master.

@rethab
Copy link
Contributor Author

rethab commented Aug 13, 2019

Nice. Could you please do that?

@fralken
Copy link
Owner

fralken commented Aug 13, 2019

Ok, I just published version 0.0.12. I created a branch cache with these commits. It would be nice if you could port this to master with a new PR.

@rethab
Copy link
Contributor Author

rethab commented Aug 20, 2019

See PR #76

@fralken fralken merged commit 47adeec into fralken:master Aug 20, 2019
fralken added a commit that referenced this pull request Aug 20, 2019
fralken added a commit that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants