Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancelled animations neglecting to notify they are done #1299

Merged

Conversation

JacobSmith-Framer
Copy link
Contributor

No description provided.

package.json Outdated Show resolved Hide resolved
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c225c23:

Sandbox Source
Framer Motion: Simple animation Configuration
App Store UI using React and Framer Motion Configuration
Framer Motion: Reorder animation Configuration
Framer Motion: growing item positionTransition issue Configuration
Framer Motion: Image lightbox Configuration

@JacobSmith-Framer JacobSmith-Framer force-pushed the fix/cancelled-animations-notify-when-done branch 2 times, most recently from 41d1d64 to 1a67bba Compare October 21, 2021 09:49
@JacobSmith-Framer JacobSmith-Framer marked this pull request as ready for review October 21, 2021 09:49
@@ -0,0 +1,12 @@
describe("Cancelled Animation", () => {
it("Allows the ", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talk about suspense!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 🤦‍♂️

@JacobSmith-Framer JacobSmith-Framer force-pushed the fix/cancelled-animations-notify-when-done branch from 1a67bba to c225c23 Compare October 21, 2021 11:59
@mattgperry mattgperry added the automerge Land this PR label Oct 22, 2021
@mergetron mergetron bot merged commit 22601f1 into feature/perfect-projection Oct 22, 2021
@mergetron mergetron bot deleted the fix/cancelled-animations-notify-when-done branch October 22, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Land this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants