Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check the existence of Proxy #1330

Merged
merged 3 commits into from Nov 24, 2021
Merged

fix: check the existence of Proxy #1330

merged 3 commits into from Nov 24, 2021

Conversation

@ambar
Copy link
Contributor

@ambar ambar commented Nov 3, 2021

This is useful when importing the package in legacy browsers (especially umd).

Related: #1178
Closes: #1178

@codesandbox
Copy link

@codesandbox codesandbox bot commented Nov 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c4aa7f8:

Sandbox Source
Framer Motion: Simple animation Configuration
App Store UI using React and Framer Motion Configuration
Framer Motion: Reorder animation Configuration
Framer Motion: growing item positionTransition issue Configuration
Framer Motion: Image lightbox Configuration

@mattgperry
Copy link
Collaborator

@mattgperry mattgperry commented Nov 3, 2021

Nice approach, this would still break in older browsers but would at least allow people who need this to do

const Component = motion("div")

@ambar
Copy link
Contributor Author

@ambar ambar commented Nov 4, 2021

Also handy for calling m().

In current version we cannot construct m() because createDomMotionConfig is not exported.

@mattgperry mattgperry merged commit 177827f into framer:main Nov 24, 2021
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants