Fixing layout projection with motion(Fragment) nodes
#2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangq
approved these changes
Apr 3, 2024
| @@ -20,6 +20,13 @@ export interface DOMVisualElementOptions { | |||
| */ | |||
| allowTransformNone?: boolean | |||
|
|
|||
| /** | |||
| * If `true`, this element will be included in the projection tree. | |||
There was a problem hiding this comment.
Good point will make this stricter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips adding
motion(Fragment)nodes to the layout projection tree.We added these nodes to allow animating variants via a renderless component rather than being bound to a
divetc (@adamseckel has more context)The problem with these nodes is layout animation scale correction is presumed to be performed by a child node, thus these nodes were swallowing the scale corrective calculations.