Fixing exit variant propagation #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0f47a44:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #345
This fixes a regression where
exitvariants stopped propagating.Every render, a
motioncomponent clears its children, which then each re-subscribe. This is done to ensure we keep the stagger order refreshed in case children change order.When we remove a child from
AnimatePresencewe keep it around until allexitanimations have completed. We do this by usingReact.cloneElement- this will re-render the top-level component but its children don't technically rerender. So the top-level component removes all its children but they don't resubscribe, so theexitanimation doesn't propagate to them.This PR adds a check - if this component is exiting, don't unsubscribe its children.