Fix/magic rotate #516
Merged
Fix/magic rotate #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d0995f7:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a10a307:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 557602b:
|
mattgperry
added a commit
that referenced
this pull request
Jun 19, 2020
* Fixing rotate * 2.0.0-beta.53 * Updating API * Rotation fix * 2.0.0-beta.54
mattgperry
added a commit
that referenced
this pull request
Jul 9, 2020
* Fixing rotate * 2.0.0-beta.53 * Updating API * Rotation fix * 2.0.0-beta.54
mattgperry
added a commit
that referenced
this pull request
Jul 15, 2020
* Fixing SVG types * Updating API * Fixing visual flicker * Debugging lifecycles * Trying demo with just one * Adding boxShadow support * Fixing rotation on initial render * 2.0.0-beta.8 * Rewriting components lifecycle-first * Rearchitecture * Fixing shared persistent animations * Fixing some magic context inheritence problems * Fixing rotation * 2.0.0-beta.9 * Fixing exports * 2.0.0-beta.10 * Use individual coordinate border radii values * Removing mid-animation jitters * 2.0.0-beta.11 * Changing tests * Latest * 2.0.0-beta.12 * Integrating AnimatePresence improvements * 2.0.0-beta.13 * Fixing FLIP animations * Fixing animatePresence flicker * 2.0.0-beta.14 * Latest * Removing Presence warning * 2.0.0-beta.15 * Adding magic dependency * 2.0.0-beta.16 * Adding warning for display: inline * 2.0.0-beta.17 * Adding crossfade * 2.0.0-beta.18 * Increasing crossfade opacity easing * 2.0.0-beta.19 * Removing fade out on overlaying component * 2.0.0-beta.20 * Updating with magicSetup * Refactoring crossfade and bug fixes * 2.0.0-beta.21 * Updating app store demo * Adding dependency prop * Updating magic * 2.0.0-beta.22 * Changing MagicMotion dependency logic * 2.0.0-beta.23 * Addig force render count * 2.0.0-beta.24 * Fixing magicId check * 2.0.0-beta.25 * Adjusting crossfade * 2.0.0-beta.27 * Refactoring MagicMotion component * Fixing crossfade * Fixing uncalled magic exit complete * 2.0.0-beta.28 * Fixing default opacity * 2.0.0-beta.29 * Updating Framer setup demo * Updating framer setup demo * Checking for snapshot * 2.0.0-beta.30 * Fixing crossfade in * 2.0.0-beta.31 * Fixing laodsa bug * Fixing divide by 0 error * 2.0.0-beta.32 * Updating utils tests * Missing safetoremove call * 2.0.0-beta.33 * Adding allowTransformNone * Refactored value handlers * Adding the ability to write custom value handlers * 2.0.0-beta.34 * Fixing check for style values * 2.0.0-beta.35 * Clearing all snapshots * Fixing jittery animation when a component has rotate but it isnt animating * 2.0.0-beta.36 * Adding transformPagePoint to Magic measurements * 2.0.0-beta.37 * Refactoring and allowing external injection of motion features * 2.0.0-beta.38 * Renaming MagicMotion to SharedMagicMotion * Fixing lint error * 2.0.0-beta.39 * Updating examples to use latest API * 2.0.0-beta.40 * Updating crossfade API * 2.0.0-beta.41 * Removing magicTransition prop * Removing from validprops * Replacing enum for AnimateSharedLayout type with strings * 2.0.0-beta.42 * Latest SharedLayout fixes * 2.0.0-beta.43 * Fixing SSR test * Fixing missing style bug * 2.0.0-beta.44 * Fixing single stack child crossfad * 2.0.0-beta.45 * Removing position from reset values * 2.0.0-beta.44 * 2.0.0-beta.45 * 2.0.0-beta.46 * Adding a minimum bounding box size to prevent divide by zero problems * 2.0.0-beta.47 * Halving the number of frame updates * 2.0.0-beta.48 * Removing unused import * Not updating Auto component if in SyncLayout trees * 2.0.0-beta.49 * Forcing render when performing a style reset * 2.0.0-beta.50 * Fixing interupting animations * Unsetting scheduled frame * Adding check to see whether component transitioned * 2.0.0-beta.51 * Adding drag integration * 2.0.0-beta.52 * Refactoring types * Fixing api-extractor * Updating docs and tests * Completeing auto unit tests * Adding testable transitions * Fix/magic rotate (#515) * Fixing rotate * 2.0.0-beta.53 * Updating API * Fix/magic rotate (#516) * Fixing rotate * 2.0.0-beta.53 * Updating API * Rotation fix * 2.0.0-beta.54 * Adding force render * Making crossfade animation testable * Reintroducing crossfade animation * Fixing * 2.0.0-beta.55 * 2.0.0-beta.56 * fixing stack tests * Adding stack tests * Fixing animation tests * fixing animations * Blocking re-renders during animation * 2.0.0-beta.57 * Adding border radius as a percentage support * 2.0.0-beta.58 * Adding ability to set a constraints ref thats smaller than the draggable item * Adding example for broken static styles * Fixing constraints tests * 2.0.0-beta.59 * Fixing transformTemplate in static * Updating version * Fixing test * Adding manual layoutOrder and isPresent * 2.0.0-beta.61 * Removing motionvalues that are removed from style * 2.0.0-beta.62 * Fixing value conversion with specific from * 2.0.0-beta.63 * Fixing tests * Adding onMeasureDragConstraints event handler * 2.0.0-beta.64 * Updating drag constraints resolving * 2.0.0-beta.65 * Fixing casing of module paths * Use Proxy for motion component generation (#529) * Changing code specifically to fix api-extractor bugs * Removing diff syntax * Removing unused comment * Replacing missing component exports * Fixing api extractor bugs * Fixing type compilation errors * Updating changelog * Fixing null color transitions * 2.0.0-beta.66 * Bringing back useAnimatedState * Reimplementing useAnimatedState * 2.0.0-beta.67 * Updating API * Resetting styles when layoutOrder changes * 2.0.0-beta.68 * Fixing exit animations * 2.0.0-beta.69 * Removing unused import * Reverting AnimatePresence * Removing auto animations from exit * Fixing value type conversion * 2.0.0-beta.70 * Fixing layoutOrder and crossfade in Framer * 2.0.0-beta.71 * Only taking origin bounding boxes from components that shouldAnimate * 2.0.0-beta.72 * Adding shouldAnimate to tests * Add shouldTransition prop to Auto, respect lead value * Renaming shouldAnimate prop to _shouldAnimate * Ensure exit animation _shouldAnimate is lead by correct screen * 2.0.0-beta.73 * 2.0.0-beta.74 * Adding VisualElement * Fixing tests * Adding SVG functions * Latest * Adding SVG renderer * Updating tests * Fixing SVG * Fixing tests * Fixing test * Latest * Fixing tests * Adding documentation and tests * Latest tests * Updating framer border * Reimplementing useAnimatedState * Fixing usAnimatedState reimplementation * Latest bounding box stuff * Latest * Latest * Latest drag intergration * Latest * Latest * Latest transform integration * Adding point scaling for drag * Latest * Latest * Updating changelog * Rebase * Updating tests * Latest test fixes * Updating geometry tests * Fixing use of originPoint * Latest updates * Skipping some tests * Fixing useAnimatedState * Latest test changes * Fixing test * Fixing drag to reorder sandbox * Updating examples template * Explicitly typing MotionValue * Updating targetBox with windowScroll * 2.0.0-rc.2 * Only firing onViewportBoxUpdate outside of react render * Preventing onViewportBoxUpdate from firing on render * 2.0.0-rc.3 * Changed method of ensuring targetBox is up to date with page scroll * 2.0.0-rc.4 * Fixing AnimateSharedLayout crossfade rerender bug * 2.0.0-rc.5 * Adding skip lib check to types output * Replacing getter and setter * Updating API * Updating API| * Update Motion logo in readme (#632) Adds a new 3D animated motion logo * 2.0.0-rc.6 * Updating API * 2.0.0-rc.7 * Updating API * 2.0.0 * Fixing test Co-authored-by: Adam Seckel <adam.seckel@gmail.com> Co-authored-by: Jurre Houtkamp <jurre@framer.com>
mattgperry
added a commit
that referenced
this pull request
Jul 27, 2020
* Fixing SVG types * Updating API * Fixing visual flicker * Debugging lifecycles * Trying demo with just one * Adding boxShadow support * Fixing rotation on initial render * 2.0.0-beta.8 * Rewriting components lifecycle-first * Rearchitecture * Fixing shared persistent animations * Fixing some magic context inheritence problems * Fixing rotation * 2.0.0-beta.9 * Fixing exports * 2.0.0-beta.10 * Use individual coordinate border radii values * Removing mid-animation jitters * 2.0.0-beta.11 * Changing tests * Latest * 2.0.0-beta.12 * Integrating AnimatePresence improvements * 2.0.0-beta.13 * Fixing FLIP animations * Fixing animatePresence flicker * 2.0.0-beta.14 * Latest * Removing Presence warning * 2.0.0-beta.15 * Adding magic dependency * 2.0.0-beta.16 * Adding warning for display: inline * 2.0.0-beta.17 * Adding crossfade * 2.0.0-beta.18 * Increasing crossfade opacity easing * 2.0.0-beta.19 * Removing fade out on overlaying component * 2.0.0-beta.20 * Updating with magicSetup * Refactoring crossfade and bug fixes * 2.0.0-beta.21 * Updating app store demo * Adding dependency prop * Updating magic * 2.0.0-beta.22 * Changing MagicMotion dependency logic * 2.0.0-beta.23 * Addig force render count * 2.0.0-beta.24 * Fixing magicId check * 2.0.0-beta.25 * Adjusting crossfade * 2.0.0-beta.27 * Refactoring MagicMotion component * Fixing crossfade * Fixing uncalled magic exit complete * 2.0.0-beta.28 * Fixing default opacity * 2.0.0-beta.29 * Updating Framer setup demo * Updating framer setup demo * Checking for snapshot * 2.0.0-beta.30 * Fixing crossfade in * 2.0.0-beta.31 * Fixing laodsa bug * Fixing divide by 0 error * 2.0.0-beta.32 * Updating utils tests * Missing safetoremove call * 2.0.0-beta.33 * Adding allowTransformNone * Refactored value handlers * Adding the ability to write custom value handlers * 2.0.0-beta.34 * Fixing check for style values * 2.0.0-beta.35 * Clearing all snapshots * Fixing jittery animation when a component has rotate but it isnt animating * 2.0.0-beta.36 * Adding transformPagePoint to Magic measurements * 2.0.0-beta.37 * Refactoring and allowing external injection of motion features * 2.0.0-beta.38 * Renaming MagicMotion to SharedMagicMotion * Fixing lint error * 2.0.0-beta.39 * Updating examples to use latest API * 2.0.0-beta.40 * Updating crossfade API * 2.0.0-beta.41 * Removing magicTransition prop * Removing from validprops * Replacing enum for AnimateSharedLayout type with strings * 2.0.0-beta.42 * Latest SharedLayout fixes * 2.0.0-beta.43 * Fixing SSR test * Fixing missing style bug * 2.0.0-beta.44 * Fixing single stack child crossfad * 2.0.0-beta.45 * Removing position from reset values * 2.0.0-beta.44 * 2.0.0-beta.45 * 2.0.0-beta.46 * Adding a minimum bounding box size to prevent divide by zero problems * 2.0.0-beta.47 * Halving the number of frame updates * 2.0.0-beta.48 * Removing unused import * Not updating Auto component if in SyncLayout trees * 2.0.0-beta.49 * Forcing render when performing a style reset * 2.0.0-beta.50 * Fixing interupting animations * Unsetting scheduled frame * Adding check to see whether component transitioned * 2.0.0-beta.51 * Adding drag integration * 2.0.0-beta.52 * Refactoring types * Fixing api-extractor * Updating docs and tests * Completeing auto unit tests * Adding testable transitions * Fix/magic rotate (#515) * Fixing rotate * 2.0.0-beta.53 * Updating API * Fix/magic rotate (#516) * Fixing rotate * 2.0.0-beta.53 * Updating API * Rotation fix * 2.0.0-beta.54 * Adding force render * Making crossfade animation testable * Reintroducing crossfade animation * Fixing * 2.0.0-beta.55 * 2.0.0-beta.56 * fixing stack tests * Adding stack tests * Fixing animation tests * fixing animations * Blocking re-renders during animation * 2.0.0-beta.57 * Adding border radius as a percentage support * 2.0.0-beta.58 * Adding ability to set a constraints ref thats smaller than the draggable item * Adding example for broken static styles * Fixing constraints tests * 2.0.0-beta.59 * Fixing transformTemplate in static * Updating version * Fixing test * Adding manual layoutOrder and isPresent * 2.0.0-beta.61 * Removing motionvalues that are removed from style * 2.0.0-beta.62 * Fixing value conversion with specific from * 2.0.0-beta.63 * Fixing tests * Adding onMeasureDragConstraints event handler * 2.0.0-beta.64 * Updating drag constraints resolving * 2.0.0-beta.65 * Fixing casing of module paths * Use Proxy for motion component generation (#529) * Changing code specifically to fix api-extractor bugs * Removing diff syntax * Removing unused comment * Replacing missing component exports * Fixing api extractor bugs * Fixing type compilation errors * Updating changelog * Fixing null color transitions * 2.0.0-beta.66 * Bringing back useAnimatedState * Reimplementing useAnimatedState * 2.0.0-beta.67 * Updating API * Resetting styles when layoutOrder changes * 2.0.0-beta.68 * Fixing exit animations * 2.0.0-beta.69 * Removing unused import * Reverting AnimatePresence * Removing auto animations from exit * Fixing value type conversion * 2.0.0-beta.70 * Fixing layoutOrder and crossfade in Framer * 2.0.0-beta.71 * Only taking origin bounding boxes from components that shouldAnimate * 2.0.0-beta.72 * Adding shouldAnimate to tests * Add shouldTransition prop to Auto, respect lead value * Renaming shouldAnimate prop to _shouldAnimate * Ensure exit animation _shouldAnimate is lead by correct screen * 2.0.0-beta.73 * 2.0.0-beta.74 * Adding VisualElement * Fixing tests * Adding SVG functions * Latest * Adding SVG renderer * Updating tests * Fixing SVG * Fixing tests * Fixing test * Latest * Fixing tests * Adding documentation and tests * Latest tests * Updating framer border * Reimplementing useAnimatedState * Fixing usAnimatedState reimplementation * Latest bounding box stuff * Latest * Latest * Latest drag intergration * Latest * Latest * Latest transform integration * Adding point scaling for drag * Latest * Latest * Updating changelog * Rebase * Updating tests * Latest test fixes * Updating geometry tests * Fixing use of originPoint * Latest updates * Skipping some tests * Fixing useAnimatedState * Latest test changes * Fixing test * Fixing drag to reorder sandbox * Updating examples template * Explicitly typing MotionValue * Updating targetBox with windowScroll * 2.0.0-rc.2 * Only firing onViewportBoxUpdate outside of react render * Preventing onViewportBoxUpdate from firing on render * 2.0.0-rc.3 * Changed method of ensuring targetBox is up to date with page scroll * 2.0.0-rc.4 * Fixing AnimateSharedLayout crossfade rerender bug * 2.0.0-rc.5 * Adding skip lib check to types output * Replacing getter and setter * Updating API * Updating API| * Update Motion logo in readme (#632) Adds a new 3D animated motion logo * 2.0.0-rc.6 * Updating API * 2.0.0-rc.7 * Updating API * 2.0.0 * Fixing test Co-authored-by: Adam Seckel <adam.seckel@gmail.com> Co-authored-by: Jurre Houtkamp <jurre@framer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.