Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace useLayoutEffect with useIsomorphicEffect #592

Merged
merged 2 commits into from Jun 16, 2020
Merged

Replace useLayoutEffect with useIsomorphicEffect #592

merged 2 commits into from Jun 16, 2020

Conversation

thebuilder
Copy link
Contributor

This fixes #578 by adding a useIsomorphicEffect to use instead of useLayoutEffect.
Stops React throwing a warning when rendering serverside.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit afe3ad4:

Sandbox Source
Framer Motion: Simple animation Configuration
App Store UI using React and Framer Motion Configuration
Framer Motion: Reorder animation Configuration
Framer Motion: growing item positionTransition issue Configuration
Framer Motion: Image lightbox Configuration
adoring-fog-w75zo Issue #578

@mattgperry
Copy link
Collaborator

Great PR, thanks for this. I'll have it published sometime this morning

@mattgperry mattgperry added the automerge Land this PR label Jun 16, 2020
@mattgperry mattgperry added automerge Land this PR and removed automerge Land this PR autorebasing-failed labels Jun 16, 2020
@mattgperry mattgperry added automerge Land this PR and removed automerge Land this PR autorebasing-failed labels Jun 16, 2020
@mergetron mergetron bot merged commit b5e603d into framer:master Jun 16, 2020
@mattgperry
Copy link
Collaborator

Published in 1.11.1

@thebuilder thebuilder deleted the fix/isomorphic-effect branch June 18, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgperry mattgperry mattgperry approved these changes

Assignees
No one assigned
Labels
automerge Land this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] useLayoutEffect warning when rendering serverside
2 participants
@thebuilder @mattgperry