Cookies Request

[danielnehrig]

TODO fix tests

[danielnehrig]

i've been a bit busy i'll come back to this soon

[danielnehrig]

i'm back i'll pick this up in the upcoming week
edit: ok soon is postponed lol

[arctic-hen7]

@danielnehrig how is this going? (Btw, I noticed while looking through your code here that the cookie setting system won't work, I don't think, because the request provided to get_request_state etc. is just a clone, you'll need to use the header setting API for that I reckon.)

[danielnehrig]

@danielnehrig how is this going? (Btw, I noticed while looking through your code here that the cookie setting system won't work, I don't think, because the request provided to get_request_state etc. is just a clone, you'll need to use the header setting API for that I reckon.)

thanks for that hint i wasn't able to test the implementation at that time due to conflicts with my projects cargo release version and the perseus upstream version

there should be more then enough time for me to pick this up again after the holidays probably start next year!

[arctic-hen7]

Sounds great! No particular rush. I don't think it will impact this PR too much, but be aware that the capsules PR rewrites over 10k lines of the Perseus core, basically constituting a full rewrite. There will probably be a few merge conflicts! (Nothing about Request has changed though.)

[arctic-hen7]

@danielnehrig is it likely you'll continue work on this any time soon, or shall I close it for now?

[danielnehrig]

i'm so sorry i'm deeply burried in work at the moment
i'll revisit stuff soon if i find time :/ for now i close this since it needs to be properly done anyways

[arctic-hen7]

No problem, let me know if you can in future, but otherwise no worries, I completely understand.