App shell redesign #177
Merged
App shell redesign #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves performance substantially, especially on mobile and bandwidth-restricted devices, since interactivity requires no external network requests for fetching translations.
Also moved some internal functions into more sensible places now that the app shell has been forked into subsequent/initial loads.
This doesn't work yet, because the router state is still in limbo.
This was possible if HSR took effect before interactivity.
|
BREAKING CHANGES:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesigns the way the Perseus app shell works, including adding full automatic support for proper hydration of initial loads. This increases the time-to-interactive of all Perseus apps by making it no longer dependent on a network request of any kind --- everything is now included in the initial HTML file the client gets (not including the JS and Wasm bundles, of course). This also reduces the amount of data that needs to be transferred over the network for subsequent loads, eliminates nearly all wrapper
<div>s (making styling full-page layouts substantially easier), and substantially reduces the size of production Perseus bundles (files for subsequent loads are much lighter now).In testing with a development bundle, the basic example achieved 99 Lighthouse scores on mobile, the highest ever, so, with a production bundle of less than a fifth of the size, Perseus' performance on both desktop and mobile should be even better than it is today!
Note: this PR resolves the difference between using the
hydrateflag or not to almost nothing in terms of performance.Fixes #173.