-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker deployment docs #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work, thanks so much! Just some minor things on phrasing, and then I'd like all the Dockerfile
s to be in <details>
blocks for better scrolling support (otherwise people will have to scroll through a huge amount of code to get to what they want).
I kind of just copy pasted all the suggested changes. Be aware that I can't run the website locally anymore cause of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some spacing issues that maybe didn't go through properly. We need to have newlines after the <summary>
blocks and before the closing </details>
, otherwise the Markdown won't render properly. Otherwise great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
esbuild
andwasm-opt
optimization steps aren't explained and also there isn't any css optimizationesbuild
step included as hello world examples don't yet contain any css file, but I think this is good enough for starters. Feel free to change anything, even any of the wording used, or suggest a change.