Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker deployment docs #98

Merged
merged 3 commits into from
Jan 2, 2022
Merged

Conversation

phaleth
Copy link
Contributor

@phaleth phaleth commented Dec 22, 2021

esbuild and wasm-opt optimization steps aren't explained and also there isn't any css optimization esbuild step included as hello world examples don't yet contain any css file, but I think this is good enough for starters. Feel free to change anything, even any of the wording used, or suggest a change.

Copy link
Member

@arctic-hen7 arctic-hen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work, thanks so much! Just some minor things on phrasing, and then I'd like all the Dockerfiles to be in <details> blocks for better scrolling support (otherwise people will have to scroll through a huge amount of code to get to what they want).

docs/0.3.x/en-US/deploying/docker.md Outdated Show resolved Hide resolved
docs/0.3.x/en-US/deploying/docker.md Outdated Show resolved Hide resolved
docs/0.3.x/en-US/deploying/docker.md Outdated Show resolved Hide resolved
docs/0.3.x/en-US/deploying/docker.md Outdated Show resolved Hide resolved
docs/0.3.x/en-US/deploying/docker.md Outdated Show resolved Hide resolved
docs/0.3.x/en-US/deploying/docker.md Outdated Show resolved Hide resolved
docs/0.3.x/en-US/deploying/docker.md Outdated Show resolved Hide resolved
@phaleth
Copy link
Contributor Author

phaleth commented Dec 27, 2021

I kind of just copy pasted all the suggested changes. Be aware that I can't run the website locally anymore cause of concurrently. The error is posted #97.

Copy link
Member

@arctic-hen7 arctic-hen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some spacing issues that maybe didn't go through properly. We need to have newlines after the <summary> blocks and before the closing </details>, otherwise the Markdown won't render properly. Otherwise great, thanks!

docs/0.3.x/en-US/deploying/docker.md Show resolved Hide resolved
docs/next/en-US/deploying/docker.md Show resolved Hide resolved
Copy link
Member

@arctic-hen7 arctic-hen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@arctic-hen7 arctic-hen7 merged commit 93f2c4b into framesurge:main Jan 2, 2022
@phaleth phaleth deleted the docker-depl branch January 2, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants