-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Pass settings in initialization instead of using a separate builder package #47
Comments
Hey. Your welcome.
|
I don't think it's as heavy as you think. Most popular frameworks let browser do the work instead of the developer ;) |
I don't think that this is true words: But about current configuration style: But via CSS variables a lot of these calculations will leave, Javascript will set base CSS variables at the start of runtime. But still, there are some things:
|
I'm gonna go ahead and close this. But I would suggest you at least make it part of the same build process, and not a separate package for customizing colors and styles. |
Hey Amir, thanks for the great library.
Why don't you pass settings at initialization time and let webpack do the build process instead of building framevuerk? Something like this:
This will make customization and hot reloading much easier.
The text was updated successfully, but these errors were encountered: