Skip to content

Commit

Permalink
fix(router): fix routable modal destroy if modal route has async prop
Browse files Browse the repository at this point in the history
  • Loading branch information
nolimits4web committed May 29, 2023
1 parent 6d40482 commit 1234e78
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/core/modules/router/modal.js
Expand Up @@ -90,7 +90,12 @@ function modalLoad(modalType, route, loadOptions = {}, direction) {
modalComponent.destroy();
}
nextTick(() => {
if (modalComponent || modalParams.component || modalParams.asyncComponent) {
if (
modalComponent ||
modalParams.component ||
modalParams.asyncComponent ||
modalParams.async
) {
router.removeModal(modal.el);
}
modal.destroy();
Expand Down

0 comments on commit 1234e78

Please sign in to comment.