Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to navigate back a second time with async route when on same page #4111

Closed
peitschie opened this issue Dec 12, 2022 · 0 comments · Fixed by #4112
Closed

Unable to navigate back a second time with async route when on same page #4111

peitschie opened this issue Dec 12, 2022 · 0 comments · Fixed by #4112

Comments

@peitschie
Copy link
Contributor

  • Framework7 version: [e.g. 3.0.0]
  • Platform and Target: [e.g. iOS 11 Cordova app, or Android 8 Chrome browser]
  • Live Link or CodeSandbox: PREFERABLY (IF YOU WANT YOUR ISSUE TO BE RESOLVED ASAP). You can start from forking the following CodeSandbox template: CodeSandbox

Describe the bug

Navigating back to current URL a second time with an async route leaves allowPageChange incorrectly set to false after routing has completed.

Related to #2200. The fix for #2200 in 83abadd only addresses navigate, and missed applying the same fix on back

To Reproduce

Reproduction app at https://codesandbox.io/p/sandbox/eager-kepler-ozg9yr

Steps to reproduce the behavior:

  1. Starting on an async route
  2. Navigate forward ("Click me first" in sandbox)
  3. After arriving at the second page, navigate back to the original url exactly ("Demonstrate bug" in sandbox)
  4. Once arriving back on the original route, try and navigate back to the same url again (it MUST be an async route to show the defect)
  5. Observe that now allowPageChange remains false

Expected behavior

At step 5, allowPageChange should return to true once the back command completes without updating the page.

Actual Behavior

At step 5, allowPageChange incorrectly remains false once the back command completes without updating the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant