Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displays thumb on chrome #1163

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Displays thumb on chrome #1163

merged 1 commit into from
Feb 21, 2017

Conversation

marcsoler
Copy link

@marcsoler marcsoler commented Oct 7, 2016

Possible fix for Issue #929
To be tested on Safari (have no Apple device)

fw7

@marcsoler
Copy link
Author

Update: Tested on iOS Safari

@tobya
Copy link
Contributor

tobya commented Dec 10, 2016

@nolimits4web Is there any possibility of getting this issue merged in?

@nolimits4web
Copy link
Member

The problem with this fix is that it will be broke thumbnail and range-fill on Safari (which is actually the target for iOS theme) where it works fine

@tobya
Copy link
Contributor

tobya commented Dec 28, 2016

@nolimits4web Thanks for the feedback we can make changes to fix to not break safari

@marcsoler
Copy link
Author

marcsoler commented Dec 29, 2016

@nolimits4web @tobya I've run some tests (browserstack) on multiple iOS devices running Safari of course: Slider knob works.

iPhone 4s
bs_ios_mobile_iphone 4s 6 0 -6 0

iPad Mini
bs_ios_tablet_ipad mini-7 0

iPhone 6s
bs_realios_mobile_iphone 6s plus-9 0 1

What am I missing?

@ZanderBrown
Copy link
Contributor

This good to merge now?

@nolimits4web nolimits4web merged commit 2227930 into framework7io:master Feb 21, 2017
@nolimits4web
Copy link
Member

Merged, thanks! Sorry for the delay

@tobya
Copy link
Contributor

tobya commented Feb 21, 2017

Great news @nolimits4web @marcsoler

@martinturner
Copy link

Sorry, im trying to use the slider now too, but i still see no thumb for the slider.
Is there a file i must change myself?
I'm currently just using the code from the framework7.io page on forms.
Thank you.

@ZanderBrown ZanderBrown added this to Resolved in Bug Report Triage Jan 29, 2018
@lock
Copy link

lock bot commented Jun 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Jun 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Bug Report Triage
  
Resolved
Development

Successfully merging this pull request may close these issues.

None yet

5 participants