Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to /fr for french users is broken #29

Open
alexsland opened this issue Jul 22, 2019 · 5 comments
Open

Redirect to /fr for french users is broken #29

alexsland opened this issue Jul 22, 2019 · 5 comments

Comments

@alexsland
Copy link
Member

No description provided.

@moul
Copy link
Member

moul commented Jul 22, 2019

what's the current behavior? redirecting to /en?

@moul
Copy link
Member

moul commented Jul 22, 2019

that's because the file _redirects is at the root of the repo, it should instead be placed somewhere so when hugo builds the website, the file is at the root like a favicon.ico or robots.txt

@moul
Copy link
Member

moul commented Aug 21, 2019

@alexsland still broken?

@cdeleeuwe
Copy link
Collaborator

It seems that when sending multiple languages in the "Accept-Language" header, Netlify always returns the default language.

Some tests:

$ curl https://deploy-preview-75--p2pparis.netlify.com
Redirecting to /en/
$ curl -H 'accept-language: fr' https://deploy-preview-75--p2pparis.netlify.com
Redirecting to /fr/
$ curl -H 'accept-language: fr,en' https://deploy-preview-75--p2pparis.netlify.com
Redirecting to /en/

Anyway, I have already contact Netlify support about it, and they are currently checking.

@cdeleeuwe
Copy link
Collaborator

Netlify support came back.. their reply:
"it is a bug which we may not get a fix for soon. I'll update you via email in case things do change though!".

So I think for now there is not much we can do about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants