Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeShapeImpl.setUri(String uri) method code missing #9

Closed
ParkHanbum opened this issue Aug 25, 2013 · 1 comment
Closed

NodeShapeImpl.setUri(String uri) method code missing #9

ParkHanbum opened this issue Aug 25, 2013 · 1 comment
Assignees
Labels

Comments

@ParkHanbum
Copy link

hi~ first, thank u for gexf4j. good job!

I find missing code block.
here

===== current ===========
@OverRide
public NodeShapeEntity setUri(String uri) {
checkArgument(uri != null, "URI cannot be set to null.");
return this;
}

==== maybe, this is right ===========
@OverRide
public NodeShapeEntity setUri(String uri) {
checkArgument(uri != null, "URI cannot be set to null.");
this.uri = uri;
return this;
}

it works!
handle on NodeShapeEntityWriter.

==============NodeShapeEntityWriter ======================
@OverRide
protected void writeAttributes() throws XMLStreamException {
writer.writeAttribute(
ATTRIB_VALUE,
entity.getNodeShape().toString().toLowerCase());

    if (entity.hasUri()) {
        writer.writeAttribute(
                ATTRIB_URI,
                entity.getUri());
    }
}

so, result
like this

#
@francesco-ficarola
Copy link
Owner

Hi,

thank you for your contribution. You're right and I fixed the bug. I've also made other minor changes and I've released the version 0.4.4-BETA. The maven synchronization for the newer version will happen in a few hours, so please check it later: http://search.maven.org/#browse%7C322148902. Alternatively and in the meantime, you can update your local github version to try your test again.

Please let me know if the fix solves your problem in order to close this issue.

Thank you again.

Best regards,
Francesco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants