fix + test, for remotion of elements turning into a default value

francescoalemanno · Mar 6, 2020 · 311bfa6 · 311bfa6 · francescoalemanno · Mar 6, 2020
1 parent f5392e2
commit 311bfa6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/DefaultArrays.jl b/src/DefaultArrays.jl
@@ -49,7 +49,7 @@ end
 @inline function setindex!(A::DefaultArray, v, i::Int)
     @boundscheck checkbounds(A, i)
     if v == A.default
-        haskey(A.elements, i) || delete!(A.elements, i)
+        haskey(A.elements, i) && delete!(A.elements, i)
     else
         A.elements[i] = v
     end

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -11,6 +11,10 @@ using LinearAlgebra
     @test A[4]==A[2,2]
     @test all(collect(eachnondefault(A)).==[4, 3])
     @test collect(eachnondefault(A,IndexCartesian())) == [CartesianIndex(2, 2), CartesianIndex(1, 2)]
+    l1=length(eachnondefault(A)|>collect)
+    A[1,2]=Inf
+    l2=length(eachnondefault(A)|>collect)
+    @test l1>l2
     B=DefaultArray(Inf,(3,))
     B[3]=2
     @test B[3]==2