Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add negative duration #3

Closed
toirl opened this issue Apr 5, 2018 · 4 comments
Closed

Add negative duration #3

toirl opened this issue Apr 5, 2018 · 4 comments
Labels
suggestion

Comments

@toirl
Copy link

toirl commented Apr 5, 2018

It would be nice to allow negative timeshift. At leaste the ISO8601 allows a negative notation.
@FrancescoBorzi
Copy link
Owner

can you please link some reference about how exactly is the standard allowing the negative notation?

I can't find anything here: https://en.wikipedia.org/wiki/ISO_8601#Durations

@toirl
Copy link
Author

toirl commented Apr 9, 2018

Yes I can't find it there too. Maybe I was misleaded because the Java documentation https://docs.oracle.com/javase/8/docs/api/java/time/Duration.html#parse-java.lang.CharSequence- implies that it is possible but also says that it is not part of the 8601.

Is there anything wrong with implementing it anyway?

@FrancescoBorzi
Copy link
Owner

nothing wrong as long as it doesn't break the current behaviour, feel free to provide a Pull Request for this feature

@FrancescoBorzi
Copy link
Owner

closing since it's not a real issue

@DerHahne DerHahne mentioned this issue May 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FrancescoBorzi @toirl