Skip to content
This repository has been archived by the owner on Nov 20, 2020. It is now read-only.

Variables on Docker Compose #66

Closed
wants to merge 4 commits into from
Closed

Variables on Docker Compose #66

wants to merge 4 commits into from

Conversation

allamand
Copy link

@allamand allamand commented Nov 9, 2016

Hi this pull request may be a respond to issue #31

It add the ability for docker-compose to be configured with :

  • a global env file for all projects at path /path/docker-projects/compose-projects.env
  • an additional project specific env file at path /path/to/docker-projects//.env

I'm very new on python dev, so don't hesitate to comment on the how I do it I can change with no problem.

…ects.env and docker-projects/<project>/.env files
@francescou
Copy link
Owner

Hi @allamand thank you for your contribution!

I will try your improvements before merging as soon as possible

@WTFKr0
Copy link
Contributor

WTFKr0 commented Nov 9, 2016

Thanks i'll try that to

@francescou
Copy link
Owner

Hi @allamand and @WTFKr0

I've made some improvement in order to support docker compose environment file, see the relative-paths branch.

You can try the example project env-sample

docker run \
    --name docker-compose-ui \
    -v $(pwd):$(pwd) \
    -w $(pwd) \
    -p 5000:5000 \
    -v /var/run/docker.sock:/var/run/docker.sock \
    francescou/docker-compose-ui:relative-paths

do you think this solution would be enought to you? this way we could also guarantee full interoperability with the docker-compose CLI.

@allamand
Copy link
Author

@francescou, Yes this works. With this i don't have anymore global env for all my projects, but it's manageable to reset them in each .env file project, and it's better has it will works the same with compose-ui or directly with compose.

Perhaps we need a way to see the content of the .env file from the UI ? or it also be useful to mask this info from users don't really have a fix idea on this point.

@francescou
Copy link
Owner

francescou commented Jan 7, 2017

Hello @allamand
in francescou/docker-compose-ui:1.1.0 you can see the docker-compose config (which contains env) in the panel "project details"

thank you for your suggestion!

@allamand
Copy link
Author

allamand commented Jan 9, 2017

Hello @francescou, very nice work this is great !!

@francescou
Copy link
Owner

I'm closing this pull request since this functionality is provided by the docker compose environment file.

feel free to reopen if necessary

@francescou francescou closed this Apr 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants