Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fix_invalid step from postcode_data_join and instead use a separate helper function #8

Open
francisbarton opened this issue Mar 26, 2024 · 1 comment

Comments

@francisbarton
Copy link
Owner

The behaviour of the fix_invalid subroutine in postcode_data_join() is a bit too haphazard to be run automatically in the middle of a user-facing function. It also makes the whole function harder to debug and read as a piece of code.

We should create a helper function that suggests replacements for invalid postcodes, and allow the user to replace these in their source data or as a step in their lookup process as they wish.

This makes it clear that any replacements are just suggestions, and it is up to the user to decide whether they are suitable.

It will also show more clearly to the user how many postcodes are invlaid, and which could be "fixed" and which could not.

francisbarton added a commit that referenced this issue Mar 26, 2024
francisbarton added a commit that referenced this issue Mar 26, 2024
@francisbarton
Copy link
Owner Author

Just need to put some tests in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant