Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues and features #11

Open
76 of 92 tasks
dav1312 opened this issue Sep 29, 2023 · 10 comments
Open
76 of 92 tasks

Issues and features #11

dav1312 opened this issue Sep 29, 2023 · 10 comments

Comments

@dav1312
Copy link

dav1312 commented Sep 29, 2023

Issues

Ubuntu-only issues?

Suggestions

@franciscoBSalgueiro
Copy link
Owner

These are great suggestions, thank you! I'll be working on them.

@franciscoBSalgueiro
Copy link
Owner

franciscoBSalgueiro commented Oct 2, 2023

If you try to analyze a previously analyzed position, the eval and depth don't update until you get a to higher depth (even if intentional it doesn't seem like a good idea)

It was intentional, I was trying to replicate the behaviour of lichess analysis. Why do you say it's a bad idea?

Being able to load multiple PGNs in the import PGN game

That should already be the case. In the Info tab there's a dropdown to choose from the games in the file. Or do you mean loading multiple files to different tabs at the same time?

@dav1312
Copy link
Author

dav1312 commented Oct 2, 2023

If you try to analyze a previously analyzed position, the eval and depth don't update until you get a to higher depth (even if intentional it doesn't seem like a good idea)

It was intentional, I was trying to replicate the behaviour of lichess analysis. Why do you say it's a bad idea?

Because moving back and forth through the game can make the engine learn more about it and newer lower depths can have more accurate evaluations than older higher depths.

If you are going to keep the engine running either way, letting the user see the updated evals shouldn't be an issue. Right now it will just take more and more resources for the user to see them.

Being able to load multiple PGNs in the import PGN game

That should already be the case. In the Info tab there's a dropdown to choose from the games in the file. Or do you mean loading multiple files to different tabs at the same time?

I mean pasting multiple games in the PGN game textarea and load them in the same way as the PGN file input does since right now it only loads the first game.

image

@dav1312
Copy link
Author

dav1312 commented Oct 10, 2023

If you try to analyze a previously analyzed position, the eval and depth don't update until you get a to higher depth (even if intentional it doesn't seem like a good idea)

It was intentional, I was trying to replicate the behaviour of lichess analysis. Why do you say it's a bad idea?

Because moving back and forth through the game can make the engine learn more about it and newer lower depths can have more accurate evaluations than older higher depths.

If you are going to keep the engine running either way, letting the user see the updated evals shouldn't be an issue. Right now it will just take more and more resources for the user to see them.

Wait (I haven't checked the actual code) but (in v0.5.0) the PID of the engine is changing every time a move is made so it seems like you are not using the same process (a common issue in chess interfaces that use Tauri) thus the engine doesn't actually learn from the game so what I said doesn't apply.

Therefore, you should prioritize fixing this and then eliminate the min depth issue.

@franciscoBSalgueiro
Copy link
Owner

App crashes trying to enable Stockfish

You used the "Save as default" feature before, right? You'll have to clear the previous saved values. I've added a button on the Help>Clear saved data for clearing all the data on localstorage.

@dav1312
Copy link
Author

dav1312 commented Nov 22, 2023

App crashes trying to enable Stockfish

You used the "Save as default" feature before, right? You'll have to clear the previous saved values. I've added a button on the Help>Clear saved data for clearing all the data on localstorage.

Ah, okay, thanks

@franciscoBSalgueiro
Copy link
Owner

It's not possible to change the number of lines of chessdb

Do you still have this issue?

@dav1312
Copy link
Author

dav1312 commented Feb 11, 2024

It's not possible to change the number of lines of chessdb

Do you still have this issue?

Yes, lichess works fine, but chessdb still doesn't

@franciscoBSalgueiro
Copy link
Owner

Just removing and then re-adding it should solve it.

@dav1312
Copy link
Author

dav1312 commented Feb 16, 2024

Just removing and then re-adding it should solve it.

yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants