Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-cluster instances to run in parallel #120

Closed
Xentrics opened this issue Jan 26, 2023 · 3 comments
Closed

Allow non-cluster instances to run in parallel #120

Xentrics opened this issue Jan 26, 2023 · 3 comments
Assignees

Comments

@Xentrics
Copy link
Contributor

Currently, the submitLocal() function in metaGEM.sh executes Snakemake with -j 1, effectively ignoring parallelization.
I suggest to change this line (358 in version 1.0.2) from

echo "snakemake all -j 1 -k"|bash; break;;

to

echo "snakemake all -j $njobs -c $ncores -k"|bash; break;;

To make full use of Snakemake.

franciscozorrilla added a commit that referenced this issue Jan 26, 2023
@franciscozorrilla
Copy link
Owner

Thanks for the useful suggestion!

@Xentrics
Copy link
Contributor Author

Apologies! I just realized a problem with that approach. To my big surprise, the jobs parameter is completely ignored when the cores parameter is specified at the same time (instead, there are as many jobs as cores) ...

I just read in the documentation for jobs that 'For local execution this is an alias for –cores.'
So we cannot have both options in local mode, because cores overwrites jobs and vice versa.

So it should only be
echo "snakemake all -j $njobs -k"|bash; break;;

@franciscozorrilla
Copy link
Owner

Ahh thanks for the clarification, I am now remembering the issues with implementing local job submission 🥲 To be honest I never really use local mode since I run my analyses on the cluster, but it does seem like there is interest in the userbase for this type of execution.

franciscozorrilla added a commit that referenced this issue Jan 26, 2023
remove conflicting `-c $ncores` parameter 💎 suggested by @Xentrics in issue #120
@franciscozorrilla franciscozorrilla self-assigned this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants