Add bar direction configuration #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a direction configuration parameter which can be set to horizontal or vertical.
This was referenced Aug 1, 2022
|
The drawing logic is too complicated for my taste (and it was complicated even before this PR). My plan is to replace it with pixman in the future. I would suggest to drop any attempts to optimize it for performance and just make it as simple as possible for now. When I wrote that |
|
Closing in favor of #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a direction configuration parameter which can be set to horizontal or vertical.
Proposed implementation for #44 which has been stuck for a while
Resolves #44