Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Don't ignore removeDuplicates option when using officialSorting #127

Closed
jbleuzen opened this issue Feb 23, 2022 · 4 comments
Closed

[Feature request] Don't ignore removeDuplicates option when using officialSorting #127

jbleuzen opened this issue Feb 23, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@jbleuzen
Copy link

Hello

Is your feature request related to a problem? Please describe.
I like both the option removeDuplicates and officialSorting but with the latest release it's documented that removeDuplicates is ignored when using officialSorting. As I think it's better to use the tailwind official sort I disabled the removeDuplicates rules.

Describe the solution you'd like
I'd like to either have an error when I have duplicated classes or get the duplicates automatically removed like before.

Describe alternatives you've considered
It's not a huge issue, I can live with the duplicated classes but if you know a way.

Thanks for considering this feature request.
@jbleuzen jbleuzen added the enhancement New feature or request label Feb 23, 2022
mpsijm added a commit to mpsijm/eslint-plugin-tailwindcss that referenced this issue Jun 7, 2022
@mpsijm
Fix francoismassart#127: Don't ignore removeDuplicates option when us…
3c4dbcf 
…ing officialSorting

The check for removing duplicates is completely separate from the
sorting, even when {officialSorting: false}. Therefore, it shouldn't
harm to also execute this check when {officialSorting: true}.
mpsijm added a commit to mpsijm/eslint-plugin-tailwindcss that referenced this issue Jun 7, 2022
@mpsijm
Fix francoismassart#127: Don't ignore removeDuplicates option when us…
10470a4 
…ing officialSorting

The check for removing duplicates is completely separate from the
sorting, even when {officialSorting: false}. Therefore, it shouldn't
harm to also execute this check when {officialSorting: true}.
@mpsijm mpsijm mentioned this issue Jun 7, 2022
Closed
12 tasks
mpsijm added a commit to mpsijm/eslint-plugin-tailwindcss that referenced this issue Jun 13, 2022
@mpsijm
Fix francoismassart#127: Don't ignore removeDuplicates option when us…
e0bd09a 
…ing officialSorting

The check for removing duplicates is completely separate from the
sorting, even when {officialSorting: false}. Therefore, it shouldn't
harm to also execute this check when {officialSorting: true}.
@francoismassart
Copy link
Owner

WIP on #132

@francoismassart francoismassart mentioned this issue Jun 20, 2022
Merged
13 tasks
@francoismassart
Copy link
Owner

I just published a beta version with the fixes listed on #132
https://github.com/francoismassart/eslint-plugin-tailwindcss/tree/fix/no-custom-classname-plugin-support#readme

npm i eslint-plugin-tailwindcss@3.6.0-beta.0

Please give it a try and provide feedback and or issues 👍
Thank you

@francoismassart
Copy link
Owner

@jbleuzen , @mpsijm & @B2o5T please try
npm i eslint-plugin-tailwindcss@3.6.0-beta.1 and share feedback.

Thanks

@francoismassart
Copy link
Owner

Should be fixed in the latest release 3.6.0

Make sure to:

  1. Update the eslint-plugin-tailwindcss package
  2. Restart your editor
  3. Report any issue on this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@jbleuzen @francoismassart