Fix parseNodeRecursive: Correctly recurse into TemplateLiteral expressions
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpsijm
force-pushed
the
fix/template-condition-expressions
branch
from
2bbb65a
to
2150235
Compare
mpsijm
force-pushed
the
fix/template-condition-expressions
branch
from
2150235
to
ab0a975
Compare
…essions In the fuction `parseNodeRecursive` of `lib/util/ast.js`, the case for TemplateListeral nodes would always recurse over `exp.right` for all expressions in the template. However, these expressions are not necessarily binary expressions. Removing the `.right` will make sure that e.g. ConditionalExpressions are also checked.
mpsijm
force-pushed
the
fix/template-condition-expressions
branch
from
ab0a975
to
ca752c9
Compare
|
Thank your for your contribution, I just released it on the beta channel: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
parseNodeRecursive: Correctly recurse into TemplateLiteral expressionsDescription
In the fuction
parseNodeRecursiveoflib/util/ast.js, the case for TemplateListeral nodes would always recurse overexp.rightfor all expressions in the template. However, these expressions are not necessarily binary expressions. Removing the.rightwill make sure that e.g. ConditionalExpressions are also checked.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've added a test to
tests/lib/rules/no-custom-classname.jsandtests/lib/rules/no-contradicting-classname.js.Test Configuration:
Checklist:
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationAny dependent changes have been merged and published in downstream modules