Automatically generate public certificates using certmagic #111

francoismichel · 2024-01-16T13:29:12Z

using the -generate-public-cert flag, a server automatically requests a public certificate using Let's Encrypt.

mpiraux

Looks good, I only have one small comment

cmd/ssh3-server/main.go

mpiraux · 2024-01-16T14:18:09Z

Even better now. Tho I started the checks again and some are still failing.

…used

francoismichel added 8 commits January 16, 2024 13:26

allow using certmagic to generate valid certificates

d676601

generate selfsigned cert only when asked

2370992

state that ZeroSSL is needed for IP certificates

e9a1813

server: rework CLI args concerning auto public certs

c21d31e

go fmt

f580ae6

go fmt

42d9157

adapt certmagic log level to the server log level

8b12cf1

go fmt

29b4114

mpiraux reviewed Jan 16, 2024

View reviewed changes

cmd/ssh3-server/main.go Outdated Show resolved Hide resolved

francoismichel added 7 commits January 16, 2024 14:37

allow distinguishing certmagic logs from ssh3 logs when certmagic is …

59cb284

…used

server: put certmagic's log at the correct log level

de9daa2

go fmt

95da370

server: enhanced logging

402e651

server: Fprintf->Fprintln

af0c2d8

server: use the TLS confic provided by certmagic if it exists

9cb1686

server: better CLI args concerning auto public certs

2567759

francoismichel merged commit c855431 into main Jan 16, 2024
29 checks passed

Provide feedback