use fqdn for module #74
Conversation
|
Before I jump into the changes, it would be nice to find a way to enforce gofmt. Ideally it would be in a separated workflow. But also being able to run it before commit would be a good thing. Maybe making a Makefile ? It could also setup a pre-commit script, but I'm not very knowledgeable on this part. |
I agree, the workflow should be turned into a makefile. as far as enforcing |
cli/client/main.go
Outdated
| @@ -648,7 +642,7 @@ func mainWithStatusCode() int { | |||
| if err != nil { | |||
| log.Fatal().Msgf("%s", err) | |||
| } | |||
| req.Proto = "ssh3" | |||
| req.Proto = "github.com/francoismichel/ssh3" | |||
There was a problem hiding this comment.
Not sure about that one, though, we're setting the :protocol HTTP/3 pseudo-header here like it is done fir webtransport, or masque. So I would let that set to ssh3 for now.
| @@ -53,7 +54,7 @@ func (i *PubKeyIdentity) Verify(genericCandidate interface{}, base64Conversation | |||
| return nil, fmt.Errorf("unsupported signature algorithm '%s' for %T", unvalidatedToken.Method.Alg(), i) | |||
| }, | |||
| jwt.WithIssuer(i.username), | |||
| jwt.WithSubject("ssh3"), | |||
| jwt.WithSubject("github.com/francoismichel/ssh3"), | |||
There was a problem hiding this comment.
same as my above comment, if another implem appears, we would not we interoperable, so I would keep ssh3 for now
server.go
Outdated
| @@ -130,7 +130,7 @@ func (s *Server) GetHTTPHandlerFunc(ctx context.Context) AuthenticatedHandlerFun | |||
|
|
|||
| return func(authenticatedUsername string, newConv *Conversation, w http.ResponseWriter, r *http.Request) { | |||
| log.Info().Msgf("got request: method: %s, URL: %s", r.Method, r.URL.String()) | |||
| if r.Method == http.MethodConnect && r.Proto == "ssh3" { | |||
| if r.Method == http.MethodConnect && r.Proto == "github.com/francoismichel/ssh3" { | |||
There was a problem hiding this comment.
Same here, I would keep ssh3 to keep interoperability
Used
gofmtto renamessh3togithub.com/francoismichel/ssh3. The code hasn't been formatted so this resulted in a lot of whitespace changes.