-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wondering why installation of a specific bower asset is incomplete #147
Comments
Sorry, I misunderstood. Indeed, the plugin only download the sources. |
I just did the tests with version Is it ok for you now? |
Hey, yeah indeed for Only I am trying to understand, what changed? Version I am happy it works, but don't understand why ;), closing issue but if you can shed some light on this magic? |
The If you use the |
Mm, ok, I guess I celebrated too early, I made a mistake when checking: I manually created a I DO have The strange thing is that this tagged branch does have the Composer output:
Resulting directory structure: There is a difference in the |
Can you give me your composer.json? |
Well, I reduced it down to the most minimal {
"require": {
"bower-asset/fullcalendar-scheduler": "~1.0"
}
} Environment:
Resulting directory listing (missing |
See my first comment. There is an inconsistency between patterns of Bower ignore and Symfony Finder. You can replace manually the filter for the moment. {
"require": {
"bower-asset/fullcalendar-scheduler": "~1.0"
},
"extra": {
"asset-ignore-files": {
"bower-asset/fullcalendar-scheduler": [
"*",
"!dist/*",
"!bower.json",
"!LICENSE.md"
]
}
}
} |
Mm, ok, your second comment made me not dive into that part so much, sorry. Now it works indeed!
Might be useful to add that to the documentation / known issues. Apparently this section is interpreted differently by Symfony Finder, resulting in removing the files for "ignore": [
"*",
"**/.*",
"!/dist/*.js",
"!/dist/*.css",
"!/CHANGELOG.*",
"!/LICENSE.*",
"!/README.*"
] Since the ignore section of "ignore": [
"*",
"**/.*",
"!/dist/**",
"!/changelog.*",
"!/license.*",
"!/readme.*"
] |
FYI, this is now fixed fullcalendar/fullcalendar-workspace#21 Inconsistency in |
"bower-asset/fullcalendar": "~2.4"
to composer.json"bower-asset/fullcalendar-scheduler": "~1.0"
to composer.jsonWhen using bower directly it DOES work:
bower install fullcalendar-scheduler
. Does the Composer Asset Plugin not support converting the used coffeescript to javascript? The bower asset that is installed properly, already contains a 'dist' folder: https://github.com/fullcalendar/fullcalendar/tree/master/dist, so I assume this is where something goes wrong / is not supported. I checked the FAQ and existing issues but could not find a relevant entry..The text was updated successfully, but these errors were encountered: