Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handleEvent errors if options is not sent as {} #32

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

hrgui
Copy link
Contributor

@hrgui hrgui commented Jun 8, 2021

When following the example in https://github.com/frandiox/vitedge/blob/master/docs/usage.md, I get the following error:

Uncaught (in promise)
TypeError: Cannot destructure property 'http2ServerPush' of 'undefined' as it is undefined.
    at T (worker.js:30:9231)
    at worker.js:30:10550
Uncaught (in response)
TypeError: Cannot destructure property 'http2ServerPush' of 'undefined' as it is undefined.

Either the example should be updated, or fallback to {} if the user doesn't pass in anything for options.

@frandiox
Copy link
Owner

frandiox commented Jun 8, 2021

Thanks!

@frandiox frandiox merged commit db2e5b8 into frandiox:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants