Better compatibility with subdomains + adding an intro to the list #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm still not sure what I'm doing.
Making that first regex experience actually work.
By trial and (mostly) error, I learned that the character `*` does not need to be escaped in the replacement string.
Adding name and url to the list, if this feature ever gets into uBlacklist (and for general ease of use) [Enhancement] Import name from list automatically iorate/ublacklist#351
"ask chatgpt for help" they told me "oh it can actually explain what the command is doing" i thougth "chatgpt is an utter and complete fool" i then realized, cursing my so-called friends
|
Hi, thanks |
|
Oops sorry, my phone lagged and I accidentally pressed close 😅 |
|
Thanks for the contribution! Everything looks good, but I prefer the list to not be sorted so it's easier to look at commit diffs - if it's sorted and you add 5 domains, they will be inserted in 5 different places in the file and so the diff will be in 5 chunks that are annoying to scroll through, but if everything is appended to the end, all the additions are shown in one chunk. So if you remove the sort command, I can merge this |
|
No problem! That's done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first experience with REGEX and a few more command lines, but it worked! It might not be up to your standards though.
www.and adding a*.before domains.list_infofile that is appended to the beginning of the blocklist file, It adds the list's name and URL, if this feature ever gets into uBlacklist (and for general ease of use) [Enhancement] Import name from list automatically [Enhancement] Import name from list automatically iorate/ublacklist#351