-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code reorganization #12
Comments
Hi, I followed your instructions to install the reorganization branch, but it still shows version 13, is it normal? Thanks |
Yes, sorry, I should have changed the version to -1 in the metadata.json. I'll fix this before merging. |
I just pushed a small fix. To update:
|
Looks like all fine but i'm on Debian and updates aren't so frequent. |
Thanks for the feedback! I added the changes to master. I'll wait a few days before uploading to extensions.gnome.org to see if anything else pops up. |
It seems to work fine for me as well (Debian 8) |
How is the icon size now? Did it improve? I made it 25% bigger. |
It works much better now. I was about to file a bug report because when I
manually update from a terminal, I need to manually click on update in the
menu to update it; I'm quite sure that didn't happen again. The icon size
is better, but I think instead of 25% 15-20% would have been better, to
match other panel items.
On Sat, May 27, 2017 at 10:53 PM Fran Glais ***@***.***> wrote:
How is the icon size now? Did it improve? I made it 25% bigger.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARILTrv5ihLFBXWQzTUK_mJ762wVZIfUks5r-JtugaJpZM4Nn-VG>
.
--
AK
|
@AravK Yeah, now the indicator will update itself every time the apt cache (or dpkg) is updated. This is not a CPU intensive task, it essentially simply runs As for the icon size, we can easily change that. @lucatrv what do you think? If you want to test a different size, you can simply modify this integer: https://github.com/franglais125/apt-update-indicator/blob/master/indicator.js#L80 Thanks again! |
The icon size looks good on my PC now with iconSize = 20, or even up to 22. |
Thank you all for your feedback! I just uploaded a new version to extensions.gnome.org. It will be ready to be updated once it passes review. You can of course install it from git if you prefer! Cheers |
Hi @lucatrv, @konkor, @AravK and anyone else!
I just committed the last bit of a code reorganization I have been doing. You can find the changes here:
https://github.com/franglais125/apt-update-indicator/tree/reorganization. This separates the main file into smaller files and classes. Hopefully it will help with maintainability and extensibility.
I have implemented a new monitor that check for changes in the apt and dpkg directories. Hence the indicator will update itself after applying updates/checking for updates, etc.!
Before committing this to the master branch and releasing a new version, I wanted to get some feedback to make sure that I didn't introduce regressions and that things are going smoothly.
To test the new branch (to be merged soon I hope):
Further suggestions are welcome of course.
Best, and thanks!
Fran
The text was updated successfully, but these errors were encountered: