Skip to content

Commit

Permalink
crypto: scompress - initialize per-CPU variables on each CPU
Browse files Browse the repository at this point in the history
commit 8c3fffe upstream.

In commit 71052dc ("crypto: scompress - Use per-CPU struct instead
multiple variables") I accidentally initialized multiple times the memory on a
random CPU. I should have initialize the memory on every CPU like it has
been done earlier. I didn't notice this because the scheduler didn't
move the task to another CPU.
Guenter managed to do that and the code crashed as expected.

Allocate / free per-CPU memory on each CPU.

Fixes: 71052dc ("crypto: scompress - Use per-CPU struct instead multiple variables")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sebastian Andrzej Siewior authored and gregkh committed Jan 25, 2024
1 parent 10d7598 commit a132ff9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions crypto/scompress.c
Expand Up @@ -79,7 +79,7 @@ static void crypto_scomp_free_scratches(void)
int i;

for_each_possible_cpu(i) {
scratch = raw_cpu_ptr(&scomp_scratch);
scratch = per_cpu_ptr(&scomp_scratch, i);

vfree(scratch->src);
vfree(scratch->dst);
Expand All @@ -96,7 +96,7 @@ static int crypto_scomp_alloc_scratches(void)
for_each_possible_cpu(i) {
void *mem;

scratch = raw_cpu_ptr(&scomp_scratch);
scratch = per_cpu_ptr(&scomp_scratch, i);

mem = vmalloc_node(SCOMP_SCRATCH_SIZE, cpu_to_node(i));
if (!mem)
Expand Down

0 comments on commit a132ff9

Please sign in to comment.