Merge pull request #154 from lmb/cmp-equal-bad-checkf

Turn a panicking cmp.Diff into a bad check
frankban · Apr 11, 2023 · 9a0c242 · 9a0c242
2 parents 6a0f8ad + 636ce19
commit 9a0c242
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/checker.go b/checker.go
@@ -131,7 +131,7 @@ func (c *cmpEqualsChecker) Check(got interface{}, args []interface{}, note func(
 		// structs with unexported fields and neither AllowUnexported nor
 		// cmpopts.IgnoreUnexported are provided.
 		if r := recover(); r != nil {
-			err = fmt.Errorf("%s", r)
+			err = BadCheckf("%s", r)
 		}
 	}()
 	want := args[0]

diff --git a/checker_test.go b/checker_test.go
@@ -538,13 +538,15 @@ want:
 	},
 	expectedCheckFailure: `
 error:
-  cannot handle unexported field at root.answer:
+  bad check: cannot handle unexported field at root.answer:
+  	"github.com/frankban/quicktest_test".(struct { answer int })
+  consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported
+`,
+	expectedNegateFailure: `
+error:
+  bad check: cannot handle unexported field at root.answer:
   	"github.com/frankban/quicktest_test".(struct { answer int })
   consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported
-got:
-  struct { answer int }{answer:42}
-want:
-  <same as "got">
 `,
 }, {
 	about:   "CmpEquals: structs with unexported fields ignored",