Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for components whose modules do not have components or overridable_attrs attributes #26

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

dev-guy
Copy link
Contributor

@dev-guy dev-guy commented Jun 15, 2023

Fixes #25

This is a placeholder. I will update this once I've finished testing.

@dev-guy dev-guy marked this pull request as draft June 15, 2023 15:45
@dev-guy
Copy link
Contributor Author

dev-guy commented Jun 15, 2023

@frankdugan3 mix test outputs the following. I don't think it's related to my changes.

== Compilation error in file lib/pyro/extension/info_test.exs ==
** (CompileError) lib/pyro/extension/info_test.exs:109: undefined function calculation/1 (there is no such import)
    (stdlib 4.3.1.1) lists.erl:1462: :lists.mapfoldl_1/3
    (ash 2.9.18) expanding macro: Ash.Resource.Dsl.Calculations.Calculate.calculate/3
    lib/pyro/extension/info_test.exs:108: Pyro.Resource.InfoTest.User (module)
    (ash 2.9.18) expanding macro: Ash.Resource.Dsl.calculations/1
    lib/pyro/extension/info_test.exs:107: Pyro.Resource.InfoTest.User (module)

@dev-guy
Copy link
Contributor Author

dev-guy commented Jun 22, 2023

@frankdugan3 Am I running the tests correctly, or are they not something that need to pass in order for my PR to be merged?

@frankdugan3
Copy link
Owner

I'm sure the failing test is a bug on my end, will merge it today as it LGTM if you take it out of draft mode.

@frankdugan3 frankdugan3 marked this pull request as ready for review June 22, 2023 13:12
@frankdugan3 frankdugan3 merged commit 9100f81 into frankdugan3:main Jun 22, 2023
@dev-guy dev-guy deleted the fix-25 branch July 13, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__on_definition__ : protocol Enumerable not implemented for nil of type Atom
2 participants