This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Rewrite baby! #81
Merged
Rewrite baby! #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure we don't try to add a video that is played to the recently played list too many times. - Make sure we don't show the "bookmark" button at times it's not needed, especially after somebody clicks it and then types a command in the command box that doesn't search for videos and update the video list.
- Add some more functionality to the DB layer and code that interacts with it
- Change name of app.js to server.js - Add index.html to root to support NW.js deployment - Set version to 1.0.0-ALPHA - Remove junk from style.css - Forgot to commit changes for api.js - Rename close method in db.js - Make small changes to toby-ui.js to support setting window title from a socket.io message. - Add method to youtube-ui.js to support snapping back to the YouTube player after exiting fullscreen in NW.js since it snaps to top of page (bug in NW.js?) - Make socket a global and put it in a script tag in index.hbs template so that all React components have access to the socket. - Remove the NW.js specific code from the layout.hbs template because that is now contained in the root level index.html file which is specific and there to support deployment in NW.js
- Add loading spinner - Check to make sure Express server is running before we set the src of the webview - Put NW.js startup code in own file
- Fix socket.io call to set title so that an empty title isn't set
- Add screenshots of what the file folders look like for people that may want to run the code but have questions about what exactly needs to be done to run the latest code.
- Trying to figure out why the README in Github is saying 404 for the new screenshots.
- Provide some information about the architecture of Toby
- Provide more details about what kinds of commands can be typed into the search box.
- Add infrastructure to support selecting a group to add a new video to. (This is not complete yet)
- Make dropdown and add button behave correctly (hopefully)
- Add license info to source files - Add a version string watermark to the UI - Remove erroneous character from package.json - Rename CSS files
- Added my video database just because. It's not needed but I'm going to include it here anyway.
- renamed starButton class to manageButton but forgot to fix all occurrences in the code
- YouTube search command is /yt now - Group listing command is /g now
- Add F11 key binding for Electron to put app in fullscreen mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.