Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete passwords even if charset file is missing #74

Open
frankhart2018 opened this issue May 10, 2024 · 2 comments
Open

Delete passwords even if charset file is missing #74

frankhart2018 opened this issue May 10, 2024 · 2 comments
Assignees
@anglerfishlyy
Labels
bug Something isn't working gssoc24 This issue can be picked up by participants of GSSoC 2024 level1 GSSoC Level 1 - 10 points task
Milestone
v0.6

Comments

@frankhart2018
Copy link
Owner

Currently if the charset file is missing, the delete endpoint: DELETE /password/:pass_uid fails with 500 when the deletion of charset fails (possible because it does not exist). This is not really required, if it cannot delete it should just move one and delete the database entry and return 200 (already exists).
@frankhart2018 frankhart2018 added bug Something isn't working gssoc24 This issue can be picked up by participants of GSSoC 2024 level1 GSSoC Level 1 - 10 points task labels May 10, 2024
@frankhart2018 frankhart2018 added this to the v0.5 milestone May 10, 2024
@anglerfishlyy
Copy link
Contributor

Could you assign me this?

@frankhart2018
Copy link
Owner Author

Assigning.

@frankhart2018 frankhart2018 modified the milestones: v0.5, v0.6 May 18, 2024
anglerfishlyy added a commit to anglerfishlyy/primistore that referenced this issue May 19, 2024
@anglerfishlyy
fixes/frankhart2018#74:[BUG]
70c412a
@frankhart2018 frankhart2018 mentioned this issue May 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anglerfishlyy anglerfishlyy

Labels
bug Something isn't working gssoc24 This issue can be picked up by participants of GSSoC 2024 level1 GSSoC Level 1 - 10 points task
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

Fixes/[BUG]: Deletes passwords even if charset file misses. anglerfishlyy/primistore
2 participants
@frankhart2018 @anglerfishlyy