-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes httpcore
import in httpx_ws/_api.py
#36
Conversation
Thank you @saforem2 for the fix! So, it seems that we also need to do that here: httpx-ws/httpx_ws/transport.py Line 8 in f0e4d4b
I would also like to bump the dependency in |
should be good to go 🚀 |
ope, missed the import in 83bfdb3 should fix and resolve failing tests |
Lol, this one was trickier than expected! Good to go, now. Thank you for your efforts 🙏 @all-contributors add @saforem2 for bug |
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @saforem2! 🎉 |
* Fixes `httpcore` import in `httpx_ws/_api.py` * Replace `httpcore.backends` import in `httpx_ws/_api.py` * Replace `httpcore.backends` import in `httpx_ws/transport.py` * Bump `httpcore` in `pyproject.toml` * Remove `NetworkStream` import from `transport.py` * Fix `httpcore` import in `tests/test_api.py`
Fixes #35