Skip to content

Commit

Permalink
Remove explicit dependency on timely_communication where not required
Browse files Browse the repository at this point in the history
Signed-off-by: Moritz Hoffmann <moritz.hoffmann@inf.ethz.ch>
  • Loading branch information
Moritz Hoffmann committed Jun 29, 2018
1 parent f47d829 commit 62f0e7c
Show file tree
Hide file tree
Showing 10 changed files with 17 additions and 26 deletions.
1 change: 0 additions & 1 deletion Cargo.toml
Expand Up @@ -26,7 +26,6 @@ graph_map = { git = "https://github.com/frankmcsherry/graph-map.git" }
abomonation = "0.5"
abomonation_derive = "0.3"
timely_sort="0.1.6"
timely_communication = "0.5"
timely = { git = "https://github.com/frankmcsherry/timely-dataflow" }
fnv="1.0.2"

Expand Down
5 changes: 3 additions & 2 deletions examples/deals.rs
Expand Up @@ -10,6 +10,7 @@ use std::time::Instant;
// use rand::{Rng, SeedableRng, StdRng};

use timely::dataflow::*;
use timely::dataflow::scopes::ScopeParent;

use differential_dataflow::input::Input;
use differential_dataflow::Collection;
Expand All @@ -23,7 +24,7 @@ use differential_dataflow::trace::implementations::ord::OrdValSpine as DefaultVa
use differential_dataflow::operators::arrange::TraceAgent;
use differential_dataflow::operators::arrange::Arranged;

type Arrange<G: Scope, K, V, R> = Arranged<G, K, V, R, TraceAgent<K, V, G::Timestamp, R, DefaultValTrace<K, V, G::Timestamp, R>>>;
type Arrange<G, K, V, R> = Arranged<G, K, V, R, TraceAgent<K, V, <G as ScopeParent>::Timestamp, R, DefaultValTrace<K, V, <G as ScopeParent>::Timestamp, R>>>;

type Node = u32;
// type Edge = (Node, Node);
Expand Down Expand Up @@ -270,4 +271,4 @@ where G::Timestamp: Lattice+Ord {
.distinct()
}
)
}
}
9 changes: 4 additions & 5 deletions examples/graspan.rs
@@ -1,17 +1,16 @@
extern crate indexmap;
extern crate timely;
extern crate timely_communication;
extern crate differential_dataflow;

use std::io::{BufRead, BufReader};
use std::fs::File;

use indexmap::IndexMap;

use timely_communication::Allocate;
use timely::Allocate;

use timely::dataflow::Scope;
use timely::dataflow::scopes::{Root, Child};
use timely::dataflow::scopes::{ScopeParent, Root, Child};
use timely::progress::timestamp::RootTimestamp;
use timely::progress::nested::product::Product;
use timely::progress::Timestamp;
Expand Down Expand Up @@ -78,7 +77,7 @@ use differential_dataflow::operators::arrange::{Arranged, TraceAgent};

type TraceKeyHandle<K,T,R> = TraceAgent<K, (), T, R, OrdKeySpine<K, T, R>>;
type TraceValHandle<K,V,T,R> = TraceAgent<K, V, T, R, OrdValSpine<K, V, T, R>>;
type Arrange<G: Scope, K, V, R> = Arranged<G, K, V, R, TraceValHandle<K, V, G::Timestamp, R>>;
type Arrange<G, K, V, R> = Arranged<G, K, V, R, TraceValHandle<K, V, <G as ScopeParent>::Timestamp, R>>;

/// An evolving set of edges.
///
Expand Down Expand Up @@ -276,4 +275,4 @@ fn main() {
if index == 0 { println!("{:?}:\tData loaded", timer.elapsed()); }

}).expect("Timely computation did not complete cleanly");
}
}
1 change: 0 additions & 1 deletion experiments/Cargo.toml
Expand Up @@ -8,7 +8,6 @@ core_affinity = "0.5.9"
rand="0.3.13"
abomonation = "0.5"
abomonation_derive = "0.3"
timely_communication = "0.5"
timely = { git = "https://github.com/frankmcsherry/timely-dataflow" }
differential-dataflow = { path = "../" }
graph_map = { git = "https://github.com/frankmcsherry/graph-map" }
4 changes: 2 additions & 2 deletions server/Cargo.toml
Expand Up @@ -9,7 +9,7 @@ path="../"
[dependencies]
rand="0.3.13"
libloading="*"
timely_communication = "0.5"
timely_communication = "0.6"
timely = { git = "https://github.com/frankmcsherry/timely-dataflow" }

#[workspace]
Expand All @@ -18,4 +18,4 @@ timely = { git = "https://github.com/frankmcsherry/timely-dataflow" }
# "dataflows/degr_dist",
# "dataflows/neighborhood",
# "dataflows/reachability"
#]
#]
11 changes: 4 additions & 7 deletions src/input.rs
Expand Up @@ -6,7 +6,7 @@
//! timely dataflow capabilities, exposing more concurrency to the operator implementations
//! than are evident from the logical times, which appear to execute in sequence.

use timely_communication::Allocate;
use timely::Allocate;

use timely::progress::Timestamp;
use timely::progress::timestamp::RootTimestamp;
Expand All @@ -26,10 +26,9 @@ pub trait Input<'a, A: Allocate, T: Timestamp+Ord> {
///
/// ```
/// extern crate timely;
/// extern crate timely_communication;
/// extern crate differential_dataflow;
///
/// use timely_communication::Configuration;
/// use timely::Configuration;
/// use differential_dataflow::input::Input;
///
/// fn main() {
Expand Down Expand Up @@ -58,10 +57,9 @@ pub trait Input<'a, A: Allocate, T: Timestamp+Ord> {
///
/// ```
/// extern crate timely;
/// extern crate timely_communication;
/// extern crate differential_dataflow;
///
/// use timely_communication::Configuration;
/// use timely::Configuration;
/// use differential_dataflow::input::Input;
///
/// fn main() {
Expand Down Expand Up @@ -115,10 +113,9 @@ impl<'a, A: Allocate, T: Timestamp+Ord> Input<'a, A, T> for Child<'a, Root<A>, T
///
/// ```
/// extern crate timely;
/// extern crate timely_communication;
/// extern crate differential_dataflow;
///
/// use timely_communication::Configuration;
/// use timely::Configuration;
/// use differential_dataflow::input::Input;
///
/// fn main() {
Expand Down
1 change: 0 additions & 1 deletion src/lib.rs
Expand Up @@ -89,7 +89,6 @@ impl<T: timely::ExchangeData + Ord + Debug> Data for T { }
extern crate fnv;
extern crate timely;
extern crate timely_sort;
extern crate timely_communication;

#[macro_use]
extern crate abomonation_derive;
Expand Down
3 changes: 1 addition & 2 deletions src/operators/arrange.rs
Expand Up @@ -249,10 +249,9 @@ where T: Lattice+Ord+Clone+'static, Tr: TraceReader<K,V,T,R> {
///
/// ```
/// extern crate timely;
/// extern crate timely_communication;
/// extern crate differential_dataflow;
///
/// use timely_communication::Configuration;
/// use timely::Configuration;
/// use differential_dataflow::input::Input;
/// use differential_dataflow::operators::arrange::Arrange;
/// use differential_dataflow::operators::group::GroupArranged;
Expand Down
5 changes: 2 additions & 3 deletions tests/bfs.rs
@@ -1,13 +1,12 @@
extern crate rand;
extern crate timely;
extern crate timely_communication;
extern crate differential_dataflow;

use rand::{Rng, SeedableRng, StdRng};

use std::sync::{Arc, Mutex};

use timely_communication::Configuration;
use timely::Configuration;

use timely::dataflow::*;
use timely::dataflow::operators::Capture;
Expand Down Expand Up @@ -220,4 +219,4 @@ where G::Timestamp: Lattice+Ord {
.concat(&nodes)
.group(|_, s, t| t.push((*s[0].0, 1)))
})
}
}
3 changes: 1 addition & 2 deletions tests/scc.rs
@@ -1,6 +1,5 @@
extern crate rand;
extern crate timely;
extern crate timely_communication;
extern crate differential_dataflow;

use rand::{Rng, SeedableRng, StdRng};
Expand All @@ -10,7 +9,7 @@ use std::collections::{HashMap, HashSet};
use std::hash::Hash;
use std::mem;

use timely_communication::Configuration;
use timely::Configuration;

use timely::dataflow::*;
use timely::dataflow::operators::Capture;
Expand Down

0 comments on commit 62f0e7c

Please sign in to comment.