Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status view shows toolbar hints, even if the sidebar is hidden #48

Closed
liquidev opened this issue Feb 20, 2021 · 8 comments
Closed

Status view shows toolbar hints, even if the sidebar is hidden #48

liquidev opened this issue Feb 20, 2021 · 8 comments
Labels
bug Something isn't working p:normal

Comments

@liquidev
Copy link
Collaborator

The hints for toolbar buttons are shown on the status bar, despite the sidebar being hidden.

https://www.youtube.com/watch?v=DSlGExgOCrg

@franko franko added the bug Something isn't working label Feb 20, 2021
@franko
Copy link
Member

franko commented Feb 20, 2021

Oh my gosh, I will talk with the people to the Quality department because this release has really a ton of bugs! :-)

Now, I am wondering how this can happens but I have to say it is a very cool bug indeed!

@liquidev
Copy link
Collaborator Author

Fortunately though, most of these bugs stem from new features and don't break existing stuff :)

franko added a commit that referenced this issue Feb 20, 2021
@budRich
Copy link
Contributor

budRich commented Feb 20, 2021

Related to this is also: When hovering the toolbar icons the hint is shown. when hovering off, the previous state is shown. This previous state is different depending on if the mouse enters the toolbar from the sidebar (blank) or the document (document info).

imo, the content of the statusbar should not change/clear just because one hovers the sidebar.

but i also find it a bit noisy that the text animates up and down if one would "swipe" the cursor over the icons, which is probably something most would do first time just to see the hints.

I am not sure what the best would be, one thing could be to make the "hitbox" of the icons larger so all the area of the toolbar belongs to an icon, but that is a bit confusing as well..

Maybe the statusbar is wrong for displaying these hints all together, and tooltips would be more appropriate?

@budRich
Copy link
Contributor

budRich commented Feb 20, 2021

i also recorded a video, im youtuber now! https://youtu.be/a3CR7G_cwOQ (30 seconds), and i was wrong with the clearing of the statusbar when hovering the sidebar btw.

@budRich
Copy link
Contributor

budRich commented Feb 21, 2021

for le record: the statusbar is cleard when user clicks something in the statusbar, even empty area. When it is cleared, the hovering over toolbar icons looks better. Still i don't think the statusbar should get cleared when the sidebar is clicked.

@franko
Copy link
Member

franko commented Feb 21, 2021

I think my implementation of the tooltip was hastily done and not well thought. I am going to fix this, thank you for the feedback and please a wait a little bit until I fix the status bar.

@franko franko closed this as completed Feb 21, 2021
@franko
Copy link
Member

franko commented Feb 21, 2021

Fixed now in the master branch, I did it properly now. It would be nice if you can test but I am pretty confident now it is ok.

@Arty2
Copy link

Arty2 commented Nov 13, 2022

Hi @franko just installed Lite XL v2.1.0 and it looks like this is still happening.
Windows 10 here, let me know if any kind of log would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p:normal
Projects
None yet
Development

No branches or pull requests

4 participants