Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BUILD_SHARED_LIBS instead of QTKEYCHAIN_STATIC? #180

Closed
KitsuneRal opened this issue Jan 18, 2021 · 3 comments
Closed

Use BUILD_SHARED_LIBS instead of QTKEYCHAIN_STATIC? #180

KitsuneRal opened this issue Jan 18, 2021 · 3 comments

Comments

@KitsuneRal
Copy link
Contributor

Is there any particular reason why QTKEYCHAIN_STATIC is used in order to switch between static/shared library instead of BUILD_SHARED_LIBS? Is it just to build a shared library by default?
@frankosterfeld
Copy link
Owner

That seems to be the cleaner way indeed. One might keep QTKEYCHAIN_STATIC around as "alias" to not break people's builds although that somehow defeats the purpose of the cleanup...

@KitsuneRal
Copy link
Contributor Author

I think both can be supported for some transition perioud, with QTKEYCHAIN_STATIC only respected if (!DEFINED BUILD_SHARED_LIBS) (i.e., BUILD_SHARED_LIBS is literally unset, not just 0 or false).

@Be-ing
Copy link
Contributor

Be-ing commented Nov 11, 2021

Fixed in #204

Be-ing added a commit to Be-ing/qtkeychain that referenced this issue Nov 11, 2021
@Be-ing
CMake: replace QTKEYCHAIN_STATIC with standard BUILD_SHARED_LIBS
ff9e9d2 
BUILD_SHARED_LIBS is the standard CMake variable for controlling
whether libraries are built dynamically or statically. Using a
nonstandard variable requires extra work for packagers.

https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html

Fixes frankosterfeld#180
Be-ing added a commit to Be-ing/qtkeychain that referenced this issue Nov 11, 2021
@Be-ing
CMake: replace QTKEYCHAIN_STATIC with standard BUILD_SHARED_LIBS
397f729 
BUILD_SHARED_LIBS is the standard CMake variable for controlling
whether libraries are built dynamically or statically. Using a
nonstandard variable requires extra work for packagers.

https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html

Fixes frankosterfeld#180
frankosterfeld pushed a commit that referenced this issue Nov 18, 2021
@Be-ing @frankosterfeld
CMake: replace QTKEYCHAIN_STATIC with standard BUILD_SHARED_LIBS
84f786c 
BUILD_SHARED_LIBS is the standard CMake variable for controlling
whether libraries are built dynamically or statically. Using a
nonstandard variable requires extra work for packagers.

https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html

Fixes #180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frankosterfeld @Be-ing @KitsuneRal