Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5-Performance Dev: Improve HF performance in edge cases #154

Merged
merged 4 commits into from
May 10, 2023
Merged

Conversation

frankwswang
Copy link
Owner

  • Added resetThreshold keyword for xDIIS to control when to reset DIIS subspace.
  • Added computation of [FDS - SDF] (regardless of the applied iterative HF solver) for convergence criteria.
  • Added secondaryConvRatio for SCFconfig to control the convergence threshold of ΔDrms and ∇Erms.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.41 ⚠️

Comparison is base (c1b1843) 95.21% compared to head (c3731eb) 94.80%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   95.21%   94.80%   -0.41%     
==========================================
  Files          19       19              
  Lines        3157     3216      +59     
==========================================
+ Hits         3006     3049      +43     
- Misses        151      167      +16     
Impacted Files Coverage Δ
src/Tools.jl 98.37% <84.21%> (-0.78%) ⬇️
src/HartreeFock.jl 93.03% <86.02%> (-2.02%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frankwswang frankwswang merged commit df4a36a into main May 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants