Fixing issue around removing listeners #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removing listeners, the comparison of the callbacks can fail. This was best seen when trying to remove cue points.
jason-brodie-codebaby
added a commit
to jason-brodie-codebaby/projekktor
that referenced
this pull request
Jan 29, 2014
Ref issue frankyghost#21
Merged
frankyghost
added a commit
that referenced
this pull request
Jan 30, 2014
Fixing issue around removing listeners
|
It can't be like that. This version causing removal of all listeners from given type not only a specified ones and that's not the expected behavior. Please revert that merge it's erroneous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing listeners, the comparison of the callbacks can fail. This was best seen when trying to remove cue points. (See issue #20)