Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options_hash_with_defaults.md #68

Closed
wants to merge 2 commits into from
Closed

Add options_hash_with_defaults.md #68

wants to merge 2 commits into from

Conversation

abarrak
Copy link
Contributor

@abarrak abarrak commented Aug 5, 2016

No description provided.

@franzejr
Copy link
Owner

I don't think this a trick, since you are just using Hash options. This is just a feature of hashes..pass options.

@franzejr franzejr closed this Sep 18, 2016
Copy link
Owner

@franzejr franzejr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a trick.

@abarrak
Copy link
Contributor Author

abarrak commented Sep 19, 2016

My opinion is that it's a pracrice, and common one in ruby world.

http://codereview.stackexchange.com/questions/39017/setting-defaults-in-a-ruby-options-hash

@franzejr franzejr reopened this Sep 24, 2016
@franzejr
Copy link
Owner

@abarrak, sorry. I thought you were adding this to the tricks part. I've just opened the PR. Can you add also an entry to the README/List where we have all the idiomatic items ?

Thanks one more time!

@franzejr
Copy link
Owner

Thanks, @abarrak. Can you solve the merge conflicts and then I can merge it?

@abarrak
Copy link
Contributor Author

abarrak commented Sep 24, 2016

Hey Franzé ,,
I've just added the READMED entry and resolved the conflict.
Thanks 😃

@abarrak abarrak closed this Sep 24, 2016
@abarrak
Copy link
Contributor Author

abarrak commented Sep 24, 2016

Can't reopen the PR to refresh with changes. 😄

@franzejr
Copy link
Owner

I also cannot re-open this. Can you send this again?

@abarrak
Copy link
Contributor Author

abarrak commented Sep 24, 2016

Alright, new PR #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants