New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LogicException for composer ^2.3 #116
Conversation
Hmm... could we just recommend/require Composer >2.3.4 when on 2.3.x? That seems to be the release with the fix. |
Unforntunatly it isn't fixed in 2.3.4. That release fixed internal issues with the same exception. The exception still occurs on 2.4RC. Composer diagnose$ composer diagnose Exception
|
tested with composer 2.3.10 on PHP 8.1 and 7.4 and for me it fixes the problem |
This indeed looks like a BC in Composer / we weren't using it correctly the whole time. The @baukevdw could you maybe add a comment, that this is basically a |
@baukevdw apparently I don't understand how to add commits to your PR, so I created a PR in your fork to include into this PR: baukevdw#1 With this we can merge the changes. |
@apfelbox You should be able to push directly to my branch since I enabled 'Allow edits by maintainers'. But I've merged your pull-request. |
@baukevdw then maybe the Github CLI was just trolling me. 😄 Thank you for your contribution 🙌 |
I just released |
Thanks! |
Fixes #115