Fix for exception due to not defined variables

franzose · Mar 30, 2014 · abf7a98 · abf7a98
1 parent 58780a9
commit abf7a98
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/Franzose/ClosureTable/Models/Entity.php b/src/Franzose/ClosureTable/Models/Entity.php
@@ -1312,9 +1312,11 @@ protected function reorderSiblings($parentIdChanged = false)
                 $query = $this->siblings();
             }
 
-            $query->buildWherePosition($positionColumn, $range)
-                ->where($this->getKeyName(), '<>', $this->getKey())
-                ->$action($positionColumn);
+            if($action) {
+                $query->buildWherePosition($positionColumn, $range)
+                    ->where($this->getKeyName(), '<>', $this->getKey())
+                    ->$action($positionColumn);
+            }
         }
     }
 
@@ -1330,6 +1332,7 @@ protected function reorderSiblings($parentIdChanged = false)
      */
     protected function setupReordering($parentIdChanged)
     {
+        $range = $action = null;
         // If the model's parent was changed, firstly we decrement
         // positions of the 'old' next siblings of the model.
         if ($parentIdChanged === true)
@@ -1445,4 +1448,4 @@ protected function newBaseQueryBuilder()
 
         return new QueryBuilder($conn, $grammar, $conn->getPostProcessor());
     }
-}
+}